ptal

@ericl, just to confirm is the behavior the same even if the pipeline structure is changed before/after the repeat call (for example on a rewindow)?

Also, do we want to not even allow iter_epochs to be called if repeat has not been called on the Dataset?

@ericl, just to confirm is the behavior the same even if the pipeline structure is changed before/after the repeat call (for example on a rewindow)?

That's right, (re)window does not change epochs (though, it is possible re-windowed windows span epochs--- in that case the max epoch of the window is used as the epoch number).

Also, do we want to not even allow iter_epochs to be called if repeat has not been called on the Dataset?

I tried adding this earlier, but it was a bit tricky. Also, I think it's better if the user can use iter_epochs() safely even if there isn't repeat (e.g., so SGDv2 can always use iter_epochs(), regardless of whether the user repeated the data).

@clarkzinzow good catch on the more_itertools dependency, I didn't realize that was not builtin. Removed it with a custom class.